{"id":2145,"date":"2017-09-08T16:19:13","date_gmt":"2017-09-08T14:19:13","guid":{"rendered":"http:\/\/blogs.gentoo.org\/ago\/?p=2145"},"modified":"2017-09-13T22:53:08","modified_gmt":"2017-09-13T20:53:08","slug":"mp3gain-stack-based-buffer-overflow-in-filteryule-gain_analysis-c","status":"publish","type":"post","link":"https:\/\/blogs.gentoo.org\/ago\/2017\/09\/08\/mp3gain-stack-based-buffer-overflow-in-filteryule-gain_analysis-c\/","title":{"rendered":"mp3gain: stack-based buffer overflow in filterYule (gain_analysis.c)"},"content":{"rendered":"

Description<\/strong>:
\nmp3gain<\/a> is a program to analyze and adjust MP3 files to same volume.<\/p>\n

The fuzz was done via the aacgain command-line tool which uses mp3gain.
\nThe upstream project seems to be dead, so the issue wasn’t communicated to them.<\/p>\n

The complete ASan output of the issue:<\/p>\n

# aacgain -f $FILE\r\n==18941==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f2d1e9cd520 at pc 0x00000088af27 bp 0x7ffc10f47b20 sp 0x7ffc10f47b18\r\nREAD of size 8 at 0x7f2d1e9cd520 thread T0\r\n    #0 0x88af26 in filterYule \/var\/tmp\/portage\/media-sound\/aacgain-1.9\/work\/aacgain-1.9\/mp3gain\/gain_analysis.c:195\r\n    #1 0x88bfcc in AnalyzeSamples \/var\/tmp\/portage\/media-sound\/aacgain-1.9\/work\/aacgain-1.9\/mp3gain\/gain_analysis.c:344\r\n    #2 0x43e89a in main \/var\/tmp\/portage\/media-sound\/aacgain-1.9\/work\/aacgain-1.9\/mp3gain\/mp3gain.c:2281\r\n    #3 0x7f2d21465680 in __libc_start_main (\/lib64\/libc.so.6+0x20680)\r\n    #4 0x4426c8 in _start (\/usr\/bin\/aacgain+0x4426c8)\r\n\r\nAddress 0x7f2d1e9cd520 is located in stack of thread T0 at offset 9504 in frame\r\n    #0 0x4341ff in main \/var\/tmp\/portage\/media-sound\/aacgain-1.9\/work\/aacgain-1.9\/mp3gain\/mp3gain.c:1411\r\n\r\n  This frame has 7 object(s):\r\n    [32, 33) 'maxgain'\r\n    [96, 97) 'mingain'\r\n    [160, 164) 'nprocsamp'\r\n    [224, 232) 'maxsample'\r\n    [288, 9504) 'lsamples' 0x0fe623d31aa0: 00 00 00 00[f2]f2 f2 f2 00 00 00 00 00 00 00 00\r\n  0x0fe623d31ab0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe623d31ac0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe623d31ad0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe623d31ae0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe623d31af0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\nShadow byte legend (one shadow byte represents 8 application bytes):\r\n  Addressable:           00\r\n  Partially addressable: 01 02 03 04 05 06 07 \r\n  Heap left redzone:       fa\r\n  Heap right redzone:      fb\r\n  Freed heap region:       fd\r\n  Stack left redzone:      f1\r\n  Stack mid redzone:       f2\r\n  Stack right redzone:     f3\r\n  Stack partial redzone:   f4\r\n  Stack after return:      f5\r\n  Stack use after scope:   f8\r\n  Global redzone:          f9\r\n  Global init order:       f6\r\n  Poisoned by user:        f7\r\n  Container overflow:      fc\r\n  Array cookie:            ac\r\n  Intra object redzone:    bb\r\n  ASan internal:           fe\r\n  Left alloca redzone:     ca\r\n  Right alloca redzone:    cb\r\n==18941==ABORTING\r\n<\/font><\/pre>\n
Affected version:<\/strong>
\n1.5.2<\/p>\n
Fixed version:<\/strong>
\nN\/A<\/p>\n
Commit fix:<\/strong>
\nN\/A<\/p>\n
Credit:<\/strong>
\nThis bug was discovered by Agostino Sarubbo of Gentoo.<\/p>\n
CVE:<\/strong>
\nCVE-2017-14407<\/p>\n
Reproducer:<\/strong>
\nhttps:\/\/github.com\/asarubbo\/poc\/blob\/master\/00345-aacgain-stackoverflow-filterYule<\/a><\/p>\n
Timeline:<\/strong>
\n2017-08-28: bug discovered
\n2017-09-08: blog post about the issue
\n2017-09-13: CVE Assigned<\/p>\n
Note:<\/strong>
\nThis bug was found with American Fuzzy Lop<\/a>.
\nThis bug was identified with bare metal servers donated by Packet<\/a>. This work is also supported by the Core Infrastructure Initiative<\/a>.<\/p>\n
Permalink:<\/strong><\/p>\n
mp3gain: stack-based buffer overflow in filterYule (gain_analysis.c)<\/a><\/p><\/blockquote>\n