{"id":2109,"date":"2017-09-01T16:28:11","date_gmt":"2017-09-01T14:28:11","guid":{"rendered":"http:\/\/blogs.gentoo.org\/ago\/?p=2109"},"modified":"2017-09-02T13:35:45","modified_gmt":"2017-09-02T11:35:45","slug":"libzip-memory-allocation-failure-in-_zip_cdir_grow-zip_dirent-c","status":"publish","type":"post","link":"https:\/\/blogs.gentoo.org\/ago\/2017\/09\/01\/libzip-memory-allocation-failure-in-_zip_cdir_grow-zip_dirent-c\/","title":{"rendered":"libzip: memory allocation failure in _zip_cdir_grow (zip_dirent.c)"},"content":{"rendered":"<p><strong>Description<\/strong>:<br \/>\n<a href=\"https:\/\/github.com\/nih-at\/libzip\">libzip<\/a> is a library for manipulating zip archives.<\/p>\n<p>The relevant ASan output of the issue:<\/p>\n<pre><font size=\"2\"># ziptool $FILE cat index\r\n==16798==ERROR: AddressSanitizer failed to allocate 0xc0a96a2000 (827476025344) bytes of LargeMmapAllocator (error code: 12)                                                                                      \r\n==16798==Process memory map follows:                                                                                                                                                                              \r\n==16798==End of process memory map.\r\n==16798==AddressSanitizer CHECK failed: \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/sanitizer_common\/sanitizer_common.cc:120 \"((0 &amp;&amp; \"unable to mmap\")) != (0)\" (0x0, 0x0)\r\n    #0 0x4da9ef in AsanCheckFailed \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/asan_rtl.cc:69\r\n    #1 0x4f5755 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/sanitizer_common\/sanitizer_termination.cc:79\r\n    #2 0x4e4d82 in __sanitizer::ReportMmapFailureAndDie(unsigned long, char const*, char const*, int, bool) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/sanitizer_common\/sanitizer_common.cc:120\r\n    #3 0x4ee685 in __sanitizer::MmapOrDie(unsigned long, char const*, bool) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/sanitizer_common\/sanitizer_posix.cc:132\r\n    #4 0x42608a in __sanitizer::LargeMmapAllocator::Allocate(__sanitizer::AllocatorStats*, unsigned long, unsigned long) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/..\/sanitizer_common\/sanitizer_allocator_secondary.h:41\r\n    #5 0x42608a in __sanitizer::CombinedAllocator&lt;__sanitizer::SizeClassAllocator64, __sanitizer::SizeClassAllocatorLocalCache&lt;__sanitizer::SizeClassAllocator64 &gt;, __sanitizer::LargeMmapAllocator &gt;::Allocate(__sanitizer::SizeClassAllocatorLocalCache&lt;__sanitizer::SizeClassAllocator64 &gt;*, unsigned long, unsigned long, bool, bool) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/..\/sanitizer_common\/sanitizer_allocator_combined.h:70\r\n    #6 0x42608a in __asan::Allocator::Allocate(unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType, bool) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/asan_allocator.cc:407\r\n    #7 0x420d3f in __asan::asan_realloc(void*, unsigned long, __sanitizer::BufferedStackTrace*) \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/asan_allocator.cc:791\r\n    #8 0x4d0df1 in realloc \/var\/tmp\/portage\/sys-libs\/compiler-rt-sanitizers-4.0.1\/work\/compiler-rt-4.0.1.src\/lib\/asan\/asan_malloc_linux.cc:93\r\n    #9 0x7f4edab1b7e5 in _zip_cdir_grow \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_dirent.c:108:37\r\n    #10 0x7f4edab1b7e5 in _zip_cdir_new \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_dirent.c:82\r\n    #11 0x7f4edab390d0 in _zip_read_eocd64 \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:854:13\r\n    #12 0x7f4edab390d0 in _zip_read_cdir \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:285\r\n    #13 0x7f4edab390d0 in _zip_find_central_dir \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:613\r\n    #14 0x7f4edab390d0 in _zip_open \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:200\r\n    #15 0x7f4edab369b7 in zip_open_from_source \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:148:11\r\n    #16 0x7f4edab35e93 in zip_open \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/lib\/zip_open.c:74:15\r\n    #17 0x513392 in read_from_file \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/src\/ziptool.c:698:13\r\n    #18 0x513392 in main \/var\/tmp\/portage\/dev-libs\/libzip-1.2.0\/work\/libzip-1.2.0\/src\/ziptool.c:1113\r\n    #19 0x7f4ed9c43680 in __libc_start_main \/var\/tmp\/portage\/sys-libs\/glibc-2.23-r4\/work\/glibc-2.23\/csu\/..\/csu\/libc-start.c:289\r\n    #20 0x41b058 in _init (\/usr\/bin\/ziptool+0x41b058)\r\n<\/font><\/pre>\n<p><strong>Affected version:<\/strong><br \/>\n1.2.0<\/p>\n<p><strong>Fixed version:<\/strong><br \/>\n1.3.0<\/p>\n<p><strong>Commit fix:<\/strong><br \/>\n<a href=\"https:\/\/github.com\/nih-at\/libzip\/commit\/9b46957ec98d85a572e9ef98301247f39338a3b5\">https:\/\/github.com\/nih-at\/libzip\/commit\/9b46957ec98d85a572e9ef98301247f39338a3b5<\/a><\/p>\n<p><strong>Credit:<\/strong><br \/>\nThis bug was discovered by Agostino Sarubbo of Gentoo.<\/p>\n<p><strong>CVE:<\/strong><br \/>\nCVE-2017-14107<\/p>\n<p><strong>Reproducer:<\/strong><br \/>\n<a href=\"https:\/\/github.com\/asarubbo\/poc\/blob\/master\/00330-libzip-memallocfailure-_zip_cdir_grow\">https:\/\/github.com\/asarubbo\/poc\/blob\/master\/00330-libzip-memallocfailure-_zip_cdir_grow<\/a><\/p>\n<p><strong>Timeline:<\/strong><br \/>\n2017-08-24: bug discovered and reported to upstream<br \/>\n2017-08-29: upstream released a fix<br \/>\n2017-09-01: blog post about the issue<br \/>\n2017-09-01: CVE assigned<\/p>\n<p><strong>Note:<\/strong><br \/>\nThis bug was found with <a href=\"http:\/\/lcamtuf.coredump.cx\/afl\">American Fuzzy Lop<\/a>.<br \/>\nThis bug was identified with bare metal servers donated by <a href=\"https:\/\/www.packet.net\/\">Packet<\/a>. This work is also supported by the <a href=\"https:\/\/www.coreinfrastructure.org\">Core Infrastructure Initiative<\/a>.<\/p>\n<p><strong>Permalink:<\/strong><\/p>\n<blockquote data-secret=\"zXTdMFFtak\" class=\"wp-embedded-content\"><p><a href=\"http:\/\/blogs.gentoo.org\/ago\/2017\/09\/01\/libzip-memory-allocation-failure-in-_zip_cdir_grow-zip_dirent-c\/\">libzip: memory allocation failure in _zip_cdir_grow (zip_dirent.c)<\/a><\/p><\/blockquote>\n<p><iframe class=\"wp-embedded-content\" sandbox=\"allow-scripts\" security=\"restricted\" style=\"position: absolute; clip: rect(1px, 1px, 1px, 1px);\" src=\"http:\/\/blogs.gentoo.org\/ago\/2017\/09\/01\/libzip-memory-allocation-failure-in-_zip_cdir_grow-zip_dirent-c\/embed\/#?secret=zXTdMFFtak\" data-secret=\"zXTdMFFtak\" width=\"600\" height=\"338\" title=\"&#8220;libzip: memory allocation failure in _zip_cdir_grow (zip_dirent.c)&#8221; &#8212; agostino&#039;s blog\" frameborder=\"0\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\"><\/iframe><\/p>\n","protected":false},"excerpt":{"rendered":"<p>Description: libzip is a library for manipulating zip archives. The relevant ASan output of the issue: # ziptool $FILE cat index ==16798==ERROR: AddressSanitizer failed to allocate 0xc0a96a2000 (827476025344) bytes of LargeMmapAllocator (error code: 12) ==16798==Process memory map follows: ==16798==End of &hellip; <a href=\"https:\/\/blogs.gentoo.org\/ago\/2017\/09\/01\/libzip-memory-allocation-failure-in-_zip_cdir_grow-zip_dirent-c\/\">Continue reading <span class=\"meta-nav\">&rarr;<\/span><\/a><\/p>\n","protected":false},"author":140,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"spay_email":"","jetpack_publicize_message":"","jetpack_is_tweetstorm":false,"jetpack_publicize_feature_enabled":true},"categories":[12,10],"tags":[],"jetpack_publicize_connections":[],"jetpack_featured_media_url":"","jetpack_sharing_enabled":true,"jetpack_shortlink":"https:\/\/wp.me\/p2EaBc-y1","_links":{"self":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/2109"}],"collection":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/users\/140"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/comments?post=2109"}],"version-history":[{"count":3,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/2109\/revisions"}],"predecessor-version":[{"id":2118,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/2109\/revisions\/2118"}],"wp:attachment":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/media?parent=2109"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/categories?post=2109"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/tags?post=2109"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}