{"id":1926,"date":"2017-07-03T23:06:05","date_gmt":"2017-07-03T21:06:05","guid":{"rendered":"http:\/\/blogs.gentoo.org\/ago\/?p=1926"},"modified":"2017-07-10T12:30:56","modified_gmt":"2017-07-10T10:30:56","slug":"mpg123-global-buffer-overflow-in-iii_i_stereo-layer3-c","status":"publish","type":"post","link":"https:\/\/blogs.gentoo.org\/ago\/2017\/07\/03\/mpg123-global-buffer-overflow-in-iii_i_stereo-layer3-c\/","title":{"rendered":"mpg123: global buffer overflow in III_i_stereo (layer3.c)"},"content":{"rendered":"<p><strong>Description<\/strong>:<br \/>\n<a href=\"http:\/\/www.mpg123.org\">mpg123<\/a> is a fast console MPEG Audio Player and decoder library.<\/p>\n<p>The complete ASan output of the issue:<\/p>\n<pre><font size=\"2\"># mpg123-mpg123 -t $FILE\r\n==10588==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f01025c5cbc at pc 0x7f010229bfe3 bp 0x7ffc988ac5b0 sp 0x7ffc988ac5a8\r\nREAD of size 4 at 0x7f01025c5cbc thread T0\r\n    #0 0x7f010229bfe2 in III_i_stereo \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/layer3.c:1343:10\r\n    #1 0x7f010229bfe2 in INT123_do_layer3 \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/layer3.c:2013\r\n    #2 0x7f01021d3708 in decode_the_frame \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/libmpg123.c:710:14\r\n    #3 0x7f01021dc61d in mpg123_decode_frame \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/libmpg123.c:849:4\r\n    #4 0x535783 in play_frame \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/mpg123.c:739:7\r\n    #5 0x53a3a7 in main \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/mpg123.c:1363:8\r\n    #6 0x7f0100f1d680 in __libc_start_main \/tmp\/portage\/sys-libs\/glibc-2.23-r3\/work\/glibc-2.23\/csu\/..\/csu\/libc-start.c:289\r\n    #7 0x41bec8 in mpg123_seek_frame (\/usr\/bin\/mpg123-mpg123+0x41bec8)\r\n\r\n0x7f01025c5cbc is located 4 bytes to the left of global variable 'pow2_1' defined in '\/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/layer3.c:50:27' (0x7f01025c5cc0) of size 128\r\n0x7f01025c5cbc is located 28 bytes to the right of global variable 'pow1_1' defined in '\/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/layer3.c:50:13' (0x7f01025c5c20) of size 128\r\nSUMMARY: AddressSanitizer: global-buffer-overflow \/var\/tmp\/portage\/media-sound\/mpg123-1.25.0\/work\/mpg123-1.25.0\/src\/libmpg123\/layer3.c:1343:10 in III_i_stereo\r\nShadow bytes around the buggy address:\r\n  0x0fe0a04b0b40: f9 f9 f9 f9 00 04 f9 f9 f9 f9 f9 f9 00 04 f9 f9\r\n  0x0fe0a04b0b50: f9 f9 f9 f9 00 00 00 00 00 00 00 00 f9 f9 f9 f9\r\n  0x0fe0a04b0b60: 00 00 00 00 00 00 00 00 f9 f9 f9 f9 00 00 00 00\r\n  0x0fe0a04b0b70: 00 00 00 00 f9 f9 f9 f9 00 00 00 00 00 00 00 00\r\n  0x0fe0a04b0b80: f9 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00\r\n=&gt;0x0fe0a04b0b90: 00 00 00 00 f9 f9 f9[f9]00 00 00 00 00 00 00 00\r\n  0x0fe0a04b0ba0: 00 00 00 00 00 00 00 00 f9 f9 f9 f9 00 00 00 00\r\n  0x0fe0a04b0bb0: 00 00 00 00 00 00 00 00 00 00 00 00 f9 f9 f9 f9\r\n  0x0fe0a04b0bc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe0a04b0bd0: f9 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00\r\n  0x0fe0a04b0be0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\r\nShadow byte legend (one shadow byte represents 8 application bytes):\r\n  Addressable:           00\r\n  Partially addressable: 01 02 03 04 05 06 07 \r\n  Heap left redzone:       fa\r\n  Freed heap region:       fd\r\n  Stack left redzone:      f1\r\n  Stack mid redzone:       f2\r\n  Stack right redzone:     f3\r\n  Stack after return:      f5\r\n  Stack use after scope:   f8\r\n  Global redzone:          f9\r\n  Global init order:       f6\r\n  Poisoned by user:        f7\r\n  Container overflow:      fc\r\n  Array cookie:            ac\r\n  Intra object redzone:    bb\r\n  ASan internal:           fe\r\n  Left alloca redzone:     ca\r\n  Right alloca redzone:    cb\r\n==10588==ABORTING\r\n<\/font><\/pre>\n<p><strong>Affected version:<\/strong><br \/>\n1.25.1<\/p>\n<p><strong>Fixed version:<\/strong><br \/>\n1.25.2 (not released atm)<\/p>\n<p><strong>Commit fix:<\/strong><br \/>\n<a href=\"https:\/\/scm.orgis.org\/view\/mpg123\/trunk\/src\/libmpg123\/layer3.c?view=patch&amp;r1=4275&amp;r2=4274&amp;pathrev=4275\">https:\/\/scm.orgis.org\/view\/mpg123\/trunk\/src\/libmpg123\/layer3.c?view=patch&amp;r1=4275&amp;r2=4274&amp;pathrev=4275<\/a><\/p>\n<p><strong>Credit:<\/strong><br \/>\nThis bug was discovered by Agostino Sarubbo of Gentoo.<\/p>\n<p><strong>CVE:<\/strong><br \/>\nCVE-2017-11126<\/p>\n<p><strong>Reproducer:<\/strong><br \/>\n<a href=\"https:\/\/github.com\/asarubbo\/poc\/blob\/master\/00300-mpg123-globaloverflow-III_i_stereo\">https:\/\/github.com\/asarubbo\/poc\/blob\/master\/00300-mpg123-globaloverflow-III_i_stereo<\/a><\/p>\n<p><strong>Timeline:<\/strong><br \/>\n2017-06-30: bug discovered and reported to upstream<br \/>\n2017-07-03: blog post about the issue<br \/>\n2017-07-10: CVE assigned<\/p>\n<p><strong>Note:<\/strong><br \/>\nThis bug was found with <a href=\"http:\/\/lcamtuf.coredump.cx\/afl\">American Fuzzy Lop<\/a>.<\/p>\n<p><strong>Permalink:<\/strong><\/p>\n<blockquote data-secret=\"o5WVB1UGj0\" class=\"wp-embedded-content\"><p><a href=\"http:\/\/blogs.gentoo.org\/ago\/2017\/07\/03\/mpg123-global-buffer-overflow-in-iii_i_stereo-layer3-c\/\">mpg123: global buffer overflow in III_i_stereo (layer3.c)<\/a><\/p><\/blockquote>\n<p><iframe class=\"wp-embedded-content\" sandbox=\"allow-scripts\" security=\"restricted\" style=\"position: absolute; clip: rect(1px, 1px, 1px, 1px);\" src=\"http:\/\/blogs.gentoo.org\/ago\/2017\/07\/03\/mpg123-global-buffer-overflow-in-iii_i_stereo-layer3-c\/embed\/#?secret=o5WVB1UGj0\" data-secret=\"o5WVB1UGj0\" width=\"600\" height=\"338\" title=\"&#8220;mpg123: global buffer overflow in III_i_stereo (layer3.c)&#8221; &#8212; agostino&#039;s blog\" frameborder=\"0\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\"><\/iframe><\/p>\n","protected":false},"excerpt":{"rendered":"<p>Description: mpg123 is a fast console MPEG Audio Player and decoder library. The complete ASan output of the issue: # mpg123-mpg123 -t $FILE ==10588==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f01025c5cbc at pc 0x7f010229bfe3 bp 0x7ffc988ac5b0 sp 0x7ffc988ac5a8 READ of size 4 &hellip; <a href=\"https:\/\/blogs.gentoo.org\/ago\/2017\/07\/03\/mpg123-global-buffer-overflow-in-iii_i_stereo-layer3-c\/\">Continue reading <span class=\"meta-nav\">&rarr;<\/span><\/a><\/p>\n","protected":false},"author":140,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"spay_email":"","jetpack_publicize_message":"","jetpack_is_tweetstorm":false,"jetpack_publicize_feature_enabled":true},"categories":[12,10],"tags":[],"jetpack_publicize_connections":[],"jetpack_featured_media_url":"","jetpack_sharing_enabled":true,"jetpack_shortlink":"https:\/\/wp.me\/p2EaBc-v4","_links":{"self":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/1926"}],"collection":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/users\/140"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/comments?post=1926"}],"version-history":[{"count":6,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/1926\/revisions"}],"predecessor-version":[{"id":1936,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/posts\/1926\/revisions\/1936"}],"wp:attachment":[{"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/media?parent=1926"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/categories?post=1926"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.gentoo.org\/ago\/wp-json\/wp\/v2\/tags?post=1926"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}